| ||Reviews Written By This User|| |
Please Note: The following is a list of reviews that were posted anonymously from similar IP locations on the internet. Many users typically share the same IP address through their local internet service provider, therefore these reviews may have been posted from various users.
Written by Anonymous User (#1398-68) from Md, USA (Tuesday, May 15, 2007)
||Listing Reviewed: Isolating file extensions
Strengths: no comment
Weaknesses: it's wrong
Details: This code snippet is poor, and has a bug, making most of it useless/unnecessary.
str3 = intHowLong - intHowLong + 3
is subtracting intHowLong from itself.
All this does is say :
str3 = 3
It will *always* = 3. Then it uses that value in here.
strExt = Right(strFilename, str3)
You'd might as well just summarize all this down to the one line below.
strExt = Right(strFilename, 3)
The bug basically means that even checking the total length was a waste of code & time.
Better would be to look for the '.' and get the length one one side of it. Remember that not all file extensions are 3 chars long.
Review Based On: using demo only